• Joe Perches's avatar
    ethernet: Remove casts to same type · 64699336
    Joe Perches authored
    Adding casts of objects to the same type is unnecessary
    and confusing for a human reader.
    
    For example, this cast:
    
            int y;
            int *p = (int *)&y;
    
    I used the coccinelle script below to find and remove these
    unnecessary casts.  I manually removed the conversions this
    script produces of casts with __force, __iomem and __user.
    
    @@
    type T;
    T *p;
    @@
    
    -       (T *)p
    +       p
    
    A function in atl1e_main.c was passed a const pointer
    when it actually modified elements of the structure.
    
    Change the argument to a non-const pointer.
    
    A function in stmmac needed a __force to avoid a sparse
    warning.  Added it.
    Signed-off-by: default avatarJoe Perches <joe@perches.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    64699336
lp486e.c 32.1 KB