• Deepak Saxena's avatar
    [PATCH] PCI: Allow arch-specific pci_set_dma_mask and friends · 6e302b79
    Deepak Saxena authored
    The patch provides the ability for architectures to have custom
    implementations of pci_set_dma_mask() and friends (dac_set_dma_mask
    and set_consistent_dma_mask). The reason I need this is b/c I have
    a chipset (Intel ARM IXP425) that has a broken PCI interface that
    only allows PCI dma to/from the bottom 64MB of system memory.  To get
    around this limitation, I trap a custom dma-mapping implementation that
    bounces buffers outside the 64MB window. At device discover time, my
    custom platform_notify() function gets called and it sets the dma_mask
    to (64MB-1) and in ARM's dma-mapping code, I check for dma_mask != 0xffffffff
    and if that is true, I call the special bounce helpers. This works great
    except that certain drivers (e100, ide-pci) call pci_set_dma_mask()
    with 0xffffffff and the generic implementation only allows for the
    architecture-defined pci_dma_supported() to return true or false. There
    is no method for the architecture to tell the PCI layer "I can't set
    the mask to 0xffffffff, but I can set it to this other value" and there
    is no way to pass that back to the driver. What this means is that if
    I have pci_set_dma_supported() return failure on full 32-bit DMA, the
    driver will not initialize the card; however, if I return true,
    pci_set_dma_mask() will set the dma mask to full 32-bits and I can no
    longer trap and will have buffers that are not dma-able and cause
    PCI master aborts.  Both of those are not acceptable.  IMHO, the
    driver shouldn't care if the architecture has to bounce DMA outside of
    64MB and since this is not something most architectures have to worry
    about, the easiest way to get around the issue is by allowing custom
    pci_set_dma_mask() for arches that need it but keeping the generic
    implementation for those that do not.  In my case, it simply returns
    0 to the driver but keeps the device mask set to 64MB-1 so I can trap.
    6e302b79
pci.c 20.6 KB