• Imre Deak's avatar
    drm/i915: Remove the unneeded AUX power ref from intel_dp_hpd_pulse() · 6f08ebe7
    Imre Deak authored
    The power get/put was added in
    
    commit 1c767b33 ("drm/i915: take display port power domain in DP HPD handler")
    Author: Imre Deak <imre.deak@intel.com>
    Date:   Mon Aug 18 14:42:42 2014 +0300
    
    to account for the HW access in ibx_digital_port_connected(). This
    latter call was in turn removed in
    
    commit 7d23e3c3 ("drm/i915: Cleaning up intel_dp_hpd_pulse")
    Author: Shubhangi Shrivastava <shubhangi.shrivastava@intel.com>
    Date:   Wed Mar 30 18:05:23 2016 +0530
    
    after which we didn't actually need the power reference.
    
    One way we are accessing the HW during HPD pulse handling is via DP AUX
    transfers, but the transfer function takes its own reference, so doesn't
    need the reference in intel_dp_hpd_pulse().
    
    The other spot is in
    
    	intel_psr_short_pulse()->intel_psr_disable_locked()
    
    but that can only happen when the panel is enabled with the
    corresponding modeset already holding the required power reference.
    
    v2:
    - Remove the unneeded power get/put from intel_psr_disable_locked().
      (Ville)
    - Checkpatch commit quoting format fix in the commit log.
    
    Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
    Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
    Cc: José Roberto de Souza <jose.souza@intel.com>
    Signed-off-by: default avatarImre Deak <imre.deak@intel.com>
    Reviewed-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20190509173446.31095-9-imre.deak@intel.com
    6f08ebe7
intel_dp.c 206 KB