• Josh Poimboeuf's avatar
    x86/dumpstack/ftrace: Mark function graph handler function as unreliable · 6f727b84
    Josh Poimboeuf authored
    When function graph tracing is enabled for a function, its return
    address on the stack is replaced with the address of an ftrace handler
    (return_to_handler).
    
    Currently 'return_to_handler' can be reported as reliable.  That's not
    ideal, and can actually be misleading.  When saving or dumping the
    stack, you normally only care about what led up to that point (the call
    path), rather than what will happen in the future (the return path).
    
    That's especially true in the non-oops stack trace case, which isn't
    used for debugging.  For example, in a perf profiling operation,
    reporting return_to_handler() in the trace would just be confusing.
    
    And in the oops case, where debugging is important, "unreliable" is also
    more appropriate there because it serves as a hint that graph tracing
    was involved, instead of trying to imply that return_to_handler() was
    the real caller.
    Signed-off-by: default avatarJosh Poimboeuf <jpoimboe@redhat.com>
    Acked-by: default avatarSteven Rostedt <rostedt@goodmis.org>
    Cc: Andy Lutomirski <luto@amacapital.net>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Brian Gerst <brgerst@gmail.com>
    Cc: Byungchul Park <byungchul.park@lge.com>
    Cc: Denys Vlasenko <dvlasenk@redhat.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Kees Cook <keescook@chromium.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Nilay Vaish <nilayvaish@gmail.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Link: http://lkml.kernel.org/r/f8af15749c7d632d3e7f815995831d5b7f82950d.1471607358.git.jpoimboe@redhat.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    6f727b84
dumpstack.c 8 KB