• Pavel Begunkov's avatar
    io_uring: fix sqo ownership false positive warning · 70b2c60d
    Pavel Begunkov authored
    WARNING: CPU: 0 PID: 21359 at fs/io_uring.c:9042
        io_uring_cancel_task_requests+0xe55/0x10c0 fs/io_uring.c:9042
    Call Trace:
     io_uring_flush+0x47b/0x6e0 fs/io_uring.c:9227
     filp_close+0xb4/0x170 fs/open.c:1295
     close_files fs/file.c:403 [inline]
     put_files_struct fs/file.c:418 [inline]
     put_files_struct+0x1cc/0x350 fs/file.c:415
     exit_files+0x7e/0xa0 fs/file.c:435
     do_exit+0xc22/0x2ae0 kernel/exit.c:820
     do_group_exit+0x125/0x310 kernel/exit.c:922
     get_signal+0x427/0x20f0 kernel/signal.c:2773
     arch_do_signal_or_restart+0x2a8/0x1eb0 arch/x86/kernel/signal.c:811
     handle_signal_work kernel/entry/common.c:147 [inline]
     exit_to_user_mode_loop kernel/entry/common.c:171 [inline]
     exit_to_user_mode_prepare+0x148/0x250 kernel/entry/common.c:201
     __syscall_exit_to_user_mode_work kernel/entry/common.c:291 [inline]
     syscall_exit_to_user_mode+0x19/0x50 kernel/entry/common.c:302
     entry_SYSCALL_64_after_hwframe+0x44/0xa9
    
    Now io_uring_cancel_task_requests() can be called not through file
    notes but directly, remove a WARN_ONCE() there that give us false
    positives. That check is not very important and we catch it in other
    places.
    
    Fixes: 84965ff8 ("io_uring: if we see flush on exit, cancel related tasks")
    Cc: stable@vger.kernel.org # 5.9+
    Reported-by: syzbot+3e3d9bd0c6ce9efbc3ef@syzkaller.appspotmail.com
    Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
    Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
    70b2c60d
io_uring.c 245 KB