• Krzysztof Kozlowski's avatar
    regulator: s2mps11: Fix ERR_PTR dereference on GPIO lookup failure · 70ca117b
    Krzysztof Kozlowski authored
    If devm_gpiod_get_from_of_node() call returns ERR_PTR, it is assigned
    into an array of GPIO descriptors and used later because such error is
    not treated as critical thus it is not propagated back to the probe
    function.
    
    All code later expects that such GPIO descriptor is either a NULL or
    proper value.  This later might lead to dereference of ERR_PTR.
    
    Only devices with S2MPS14 flavor are affected (other do not control
    regulators with GPIOs).
    
    Fixes: 1c984942 ("regulator: s2mps11: Pass descriptor instead of GPIO number")
    Cc: <stable@vger.kernel.org>
    Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
    Signed-off-by: default avatarMark Brown <broonie@kernel.org>
    70ca117b
s2mps11.c 40.8 KB