• Tejun Heo's avatar
    libata: set queue DMA alignment to sector size for ATAPI too · 729a6a30
    Tejun Heo authored
    ata_pio_sectors() expects buffer for each sector to be contained in a
    single page; otherwise, it ends up overrunning the first page.  This
    is achieved by setting queue DMA alignment.  If sector_size is smaller
    than PAGE_SIZE and all buffers are sector_size aligned, buffer for
    each sector is always contained in a single page.
    
    This wasn't applied to ATAPI devices but IDENTIFY_PACKET is executed
    as ATA_PROT_PIO and thus uses ata_pio_sectors().  Newer versions of
    udev issue IDENTIFY_PACKET with unaligned buffer triggering the
    problem and causing oops.
    
    This patch fixes the problem by setting sdev->sector_size to
    ATA_SECT_SIZE on ATATPI devices and always setting DMA alignment to
    sector_size.  While at it, add a warning for the unlikely but still
    possible scenario where sector_size is larger than PAGE_SIZE, in which
    case the alignment wouldn't be enough.
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    Reported-by: default avatarJohn Stanley <jpsinthemix@verizon.net>
    Tested-by: default avatarJohn Stanley <jpsinthemix@verizon.net>
    Cc: stable@kernel.org
    Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
    729a6a30
libata-scsi.c 97.8 KB