• Arnd Bergmann's avatar
    crypto: ixp4xx - fix building wiht 64-bit dma_addr_t · 586d492f
    Arnd Bergmann authored
    The crypt_ctl structure must be exactly 64 bytes long to work correctly,
    and it has to be a power-of-two size to allow turning the
    64-bit division in crypt_phys2virt() into a shift operation, avoiding
    the link failure:
    
    ERROR: modpost: "__aeabi_uldivmod" [drivers/crypto/intel/ixp4xx/ixp4xx_crypto.ko] undefined!
    
    The failure now shows up because the driver is available for compile
    testing after the move, and a previous fix turned the more descriptive
    BUILD_BUG_ON() into a link error.
    
    Change the variably-sized dma_addr_t into the expected 'u32' type that is
    needed for the hardware, and reinstate the size check for all 32-bit
    architectures to simplify debugging if it hits again.
    
    Fixes: 1bc7fdbf ("crypto: ixp4xx - Move driver to drivers/crypto/intel/ixp4xx")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    586d492f
ixp4xx_crypto.c 40 KB