• Chancel Liu's avatar
    ASoC: soc-core.c: Prefer to return dai->driver->name in snd_soc_dai_name_get() · 755bb9a4
    Chancel Liu authored
    ASoC machine driver can use snd_soc_{of_}get_dlc() (A) to get DAI name
    for dlc (snd_soc_dai_link_component). In this function call
    dlc->dai_name is parsed via snd_soc_dai_name_get() (B).
    
    (A)	int snd_soc_get_dlc(...)
    	{
    		...
    (B)		dlc->dai_name = snd_soc_dai_name_get(dai);
    		...
    	}
    
    (B) has a priority to return dai->name as dlc->dai_name. In most cases
    card can probe successfully. However it has an issue that ASoC tries to
    rebind card. Here is a simplified flow for example:
    
     |	a) Card probes successfully at first
     |	b) One of the component bound to this card is removed for some
     |	   reason the component->dev is released
     |	c) That component is re-registered
     v	d) ASoC calls snd_soc_try_rebind_card()
    
    a) points dlc->dai_name to dai->name. b) releases all resource of the
    old DAI. c) creates new DAI structure. In result d) can not use
    dlc->dai_name to add new created DAI.
    
    So it's reasonable that prefer to return dai->driver->name in
    snd_soc_dai_name_get() because dai->driver is a pre-defined global
    variable. Also update snd_soc_is_matching_dai() for alignment.
    Signed-off-by: default avatarChancel Liu <chancel.liu@nxp.com>
    Link: https://msgid.link/r/20240304072128.2845432-1-chancel.liu@nxp.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    755bb9a4
soc-core.c 93 KB