• Will Deacon's avatar
    ARM: 6890/1: memmap: only free allocated memmap entries when using SPARSEMEM · 9af386c8
    Will Deacon authored
    The SPARSEMEM code allocates memmap entries only for sections which are
    present (i.e. those which contain some valid memory). The membank checks
    in free_unused_memmap do not take this into account and can incorrectly
    attempt to free memory which is not allocated, resulting in a BUG() in
    the bootmem code.
    
    However, if memory is configured as follows:
    
        |<----section---->|<----hole---->|<----section---->|
        +--------+--------+--------------+--------+--------+
        | bank 0 | unused |              | bank 1 | unused |
        +--------+--------+--------------+--------+--------+
    
    where a bank only occupies part of a section, the memmap allocated for
    the remainder of the section *can* be freed.
    
    This patch modifies the checks in free_unused_memmap so that only valid
    memmap entries are considered for removal.
    Acked-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
    Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
    Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
    9af386c8
init.c 17.2 KB