• Imre Deak's avatar
    drm/i915/ddi: Use power well CTL IDX instead of ID · 75e39688
    Imre Deak authored
    Similarly to the previous patch use a separate request/status HW flag
    index defined right after the corresponding control registers instead of
    depending for this on the power well IDs. Since the set of
    control/status registers varies among the different power wells (on a
    single platform), also add a new i915_power_well_registers struct that
    we populate and assign to each DDI power well as needed.
    
    Also clarify a bit the code comment describing the function and layout
    of the control registers.
    
    This also fixes a problem on ICL, where we incorrectly read the KVMR
    control register in hsw_power_well_requesters() even for DDI and AUX
    power wells.
    
    v2:
    - Clarify platform range tags in code comments. (Paulo)
    - Fix line over 80 chars checkpatch warning.
    
    Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
    Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
    Cc: Jani Nikula <jani.nikula@intel.com>
    Signed-off-by: default avatarImre Deak <imre.deak@intel.com>
    Reviewed-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20180806095843.13294-7-imre.deak@intel.com
    75e39688
i915_drv.h 116 KB