• Zhao Yakui's avatar
    ACPI: hack around sysfs warning with link order · 5eaff722
    Zhao Yakui authored
        There exists the following warning message will appear after the
    following commit is merged.
       >commit f2e969acd6d5981e6b1272810002558650d0736e
       >Author: Zhao Yakui <yakui.zhao@intel.com>
       >Date:   Mon Aug 11 14:57:50 2008 +0800
        >ACPI: Add "acpi.power_nocheck=1" to disable power state check in
    power transition:
    
       >WARNING: at linux-2.6/fs/sysfs/dir.c:463  sysfs_add_one+0x33/0x39()
       >sysfs: duplicate filename 'acpi' can not be created
       >kobject_add_internal failed for acpi with -EEXIST, don't try to register
                things with the same name in the same directory
    
       In the above commit the "acpi.power_nocheck" module parameter is defined
    in drivers/acpi/power.c file. As several module parameters using the same ACPI
    prefix are defined in the different files(for example: power_nocheck is
    defined in drivers/acpi/power.c,debug_layer/debug_level are defined in
    drivers/acpi/debug.c) and there exists another module between them, the
    warning message will be printed when using the current generic param code.
    (In the function of param_sysfs_init).
    
       In fact when ACPI is selected, the drivers/acpi/power will also be compiled
    as built-in kernel.So this issue can be fixed by the following approach.
       workaround it by adjusting the module link order in drivers/acpi/Makefile.
    In such case the module parameter using the same prefix(ACPI) are put together
    in the param data section.
    
       Of course the better solution is to fix it in generic param code related
    with sysfs.
    Signed-off-by: default avatarZhao Yakui <yakui.zhao@intel.com>
    Signed-off-by: default avatarLen Brown <len.brown@intel.com>
    5eaff722
Makefile 1.67 KB