• Arnaldo Carvalho de Melo's avatar
    perf script perl: Do error checking on new backtrace routine · 76e20522
    Arnaldo Carvalho de Melo authored
    This ended up triggering these warnings when building on Ubuntu 12.04.5:
    
      util/scripting-engines/trace-event-perl.c: In function 'perl_process_callchain':
      util/scripting-engines/trace-event-perl.c:293:4: error: value computed is not used [-Werror=unused-value]
      util/scripting-engines/trace-event-perl.c:294:4: error: value computed is not used [-Werror=unused-value]
      util/scripting-engines/trace-event-perl.c:295:4: error: value computed is not used [-Werror=unused-value]
      util/scripting-engines/trace-event-perl.c:297:4: error: value computed is not used [-Werror=unused-value]
      util/scripting-engines/trace-event-perl.c:309:4: error: value computed is not used [-Werror=unused-value]
      cc1: all warnings being treated as errors
      mv: cannot stat `/tmp/build/perf/util/scripting-engines/.trace-event-perl.o.tmp': No such file or directory
      make[4]: *** [/tmp/build/perf/util/scripting-engines/trace-event-perl.o] Error 1
    
    Fix it by doing error checking when building the perl data structures
    related to callchains.
    
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Dima Kogan <dima@secretsauce.net>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Namhyung Kim <namhyung@gmail.com>
    Fixes: f7380c12 ("perf script perl: Perl scripts now get a backtrace, like the python ones")
    Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    76e20522
trace-event-perl.c 17.9 KB