• Arnd Bergmann's avatar
    drm/xe: circumvent bogus stringop-overflow warning · 774ef5df
    Arnd Bergmann authored
    gcc-13 warns about an array overflow that it sees but that is
    prevented by the "asid % NUM_PF_QUEUE" calculation:
    
    drivers/gpu/drm/xe/xe_gt_pagefault.c: In function 'xe_guc_pagefault_handler':
    include/linux/fortify-string.h:57:33: error: writing 16 bytes into a region of size 0 [-Werror=stringop-overflow=]
    include/linux/fortify-string.h:689:26: note: in expansion of macro '__fortify_memcpy_chk'
      689 | #define memcpy(p, q, s)  __fortify_memcpy_chk(p, q, s,                  \
          |                          ^~~~~~~~~~~~~~~~~~~~
    drivers/gpu/drm/xe/xe_gt_pagefault.c:341:17: note: in expansion of macro 'memcpy'
      341 |                 memcpy(pf_queue->data + pf_queue->tail, msg, len * sizeof(u32));
          |                 ^~~~~~
    drivers/gpu/drm/xe/xe_gt_types.h:102:25: note: at offset [1144, 265324] into destination object 'tile' of size 8
    
    I found that rewriting the assignment using pointer addition rather than the
    equivalent array index calculation prevents the warning, so use that instead.
    
    I sent a bug report against gcc for the false positive warning.
    
    Fixes: dd08ebf6 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
    Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113214Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20240103114819.2913937-1-arnd@kernel.org
    774ef5df
xe_gt_pagefault.c 15.6 KB