• Lyude's avatar
    HID: rmi: Make sure the HID device is opened on resume · cac72b99
    Lyude authored
    So it looks like that suspend/resume has actually always been broken on
    hid-rmi. The fact it worked was a rather silly coincidence that was
    relying on the HID device to already be opened upon resume. This means
    that so long as anything was reading the /dev/input/eventX node for for
    an RMI device, it would suspend and resume correctly. As well, if
    nothing happened to be keeping the HID device away it would shut off,
    then the RMI driver would get confused on resume when it stopped
    responding and explode.
    
    So, call hid_hw_open() in rmi_post_resume() so we make sure that the
    device is alive before we try talking to it.
    
    This fixes RMI device suspend/resume over HID.
    
    Link: https://bugzilla.kernel.org/show_bug.cgi?id=196851
    [jkosina@suse.cz: removed useless hunk that was zero-initializing 'ret']
    Signed-off-by: default avatarLyude <lyude@redhat.com>
    Cc: Andrew Duggan <aduggan@synaptics.com>
    Cc: stable@vger.kernel.org
    Reviewed-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
    Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
    cac72b99
hid-rmi.c 18 KB