• Damien Le Moal's avatar
    zonefs: fix page reference and BIO leak · 6bea0225
    Damien Le Moal authored
    In zonefs_file_dio_append(), the pages obtained using
    bio_iov_iter_get_pages() are not released on completion of the
    REQ_OP_APPEND BIO, nor when bio_iov_iter_get_pages() fails.
    Furthermore, a call to bio_put() is missing when
    bio_iov_iter_get_pages() fails.
    
    Fix these resource leaks by adding BIO resource release code (bio_put()i
    and bio_release_pages()) at the end of the function after the BIO
    execution and add a jump to this resource cleanup code in case of
    bio_iov_iter_get_pages() failure.
    
    While at it, also fix the call to task_io_account_write() to be passed
    the correct BIO size instead of bio_iov_iter_get_pages() return value.
    Reported-by: default avatarChristoph Hellwig <hch@lst.de>
    Fixes: 02ef12a6 ("zonefs: use REQ_OP_ZONE_APPEND for sync DIO")
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarDamien Le Moal <damien.lemoal@wdc.com>
    Reviewed-by: default avatarChaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    6bea0225
super.c 44.4 KB