• Jiri Pirko's avatar
    devlink: move devlink reload notifications back in between _down() and _up() calls · 7d7e9169
    Jiri Pirko authored
    This effectively reverts commit 05a7f4a8 ("devlink: Break parameter
    notification sequence to be before/after unload/load driver").
    
    Cited commit resolved a problem in mlx5 params implementation,
    when param notification code accessed memory previously freed
    during reload.
    
    Now, when the params can be registered and unregistered when devlink
    instance is registered, mlx5 code unregisters the problematic param
    during devlink reload. The fix is therefore no longer needed.
    
    Current behavior is a it problematic, as it sends DEL notifications even
    in potential case when reload_down() call fails which might confuse
    userspace notifications listener.
    
    So move the reload notifications back where they were originally in
    between reload_down() and reload_up() calls.
    Signed-off-by: default avatarJiri Pirko <jiri@nvidia.com>
    Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    7d7e9169
leftover.c 316 KB