• Maxim Mikityanskiy's avatar
    Validate required parameters in inet6_validate_link_af · 7dc2bcca
    Maxim Mikityanskiy authored
    inet6_set_link_af requires that at least one of IFLA_INET6_TOKEN or
    IFLA_INET6_ADDR_GET_MODE is passed. If none of them is passed, it
    returns -EINVAL, which may cause do_setlink() to fail in the middle of
    processing other commands and give the following warning message:
    
      A link change request failed with some changes committed already.
      Interface eth0 may have been left with an inconsistent configuration,
      please check.
    
    Check the presence of at least one of them in inet6_validate_link_af to
    detect invalid parameters at an early stage, before do_setlink does
    anything. Also validate the address generation mode at an early stage.
    Signed-off-by: default avatarMaxim Mikityanskiy <maximmi@mellanox.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    7dc2bcca
addrconf.c 172 KB