• Uwe Kleine-König's avatar
    net: ethernet: ti: cpsw: Convert to platform remove callback returning void · 7ac3f867
    Uwe Kleine-König authored
    The .remove() callback for a platform driver returns an int which makes
    many driver authors wrongly assume it's possible to do error handling by
    returning an error code. However the value returned is ignored (apart
    from emitting a warning) and this typically results in resource leaks.
    
    To improve here there is a quest to make the remove callback return
    void. In the first step of this quest all drivers are converted to
    .remove_new(), which already returns void. Eventually after all drivers
    are converted, .remove_new() will be renamed to .remove().
    
    Replace the error path returning a non-zero value by an error message
    and a comment that there is more to do. With that this patch results in
    no change of behaviour in this driver apart from improving the error
    message.
    Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Reviewed-by: default avatarRoger Quadros <rogerq@kernel.org>
    Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
    7ac3f867
cpsw.c 46.1 KB