• Peter Xu's avatar
    userfaultfd: selftest: recycle lock threads first · 7eaa8c96
    Peter Xu authored
    Now we recycle the uffd servicing threads earlier than the lock threads.
    It might happen that when the lock thread is still blocked at a pthread
    mutex lock while the servicing thread has already quitted for the cpu so
    the lock thread will be blocked forever and hang the test program.  To fix
    the possible race, recycle the lock threads first.
    
    This never happens with current missing-only tests, but when I start to
    run the write-protection tests (the feature is not yet posted upstream) it
    happens every time of the run possibly because in that new test we'll need
    to service two page faults for each lock operation.
    
    Link: http://lkml.kernel.org/r/20180930074259.18229-4-peterx@redhat.comSigned-off-by: default avatarPeter Xu <peterx@redhat.com>
    Acked-by: default avatarMike Rapoport <rppt@linux.vnet.ibm.com>
    Cc: Shuah Khan <shuah@kernel.org>
    Cc: Mike Kravetz <mike.kravetz@oracle.com>
    Cc: Jerome Glisse <jglisse@redhat.com>
    Cc: Zi Yan <zi.yan@cs.rutgers.edu>
    Cc: "Kirill A . Shutemov" <kirill@shutemov.name>
    Cc: Shaohua Li <shli@fb.com>
    Cc: Andrea Arcangeli <aarcange@redhat.com>
    Cc: "Dr . David Alan Gilbert" <dgilbert@redhat.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    7eaa8c96
userfaultfd.c 34.5 KB