• Jacob Keller's avatar
    ice: convert ice_reset_vf to take flags · 7eb517e4
    Jacob Keller authored
    The ice_reset_vf function takes a boolean parameter which indicates
    whether or not the reset is due to a VFLR event.
    
    This is somewhat confusing to read because readers must interpret what
    "true" and "false" mean when seeing a line of code like
    "ice_reset_vf(vf, false)".
    
    We will want to add another toggle to the ice_reset_vf in a following
    change. To avoid proliferating many arguments, convert this function to
    take flags instead. ICE_VF_RESET_VFLR will indicate if this is a VFLR
    reset. A value of 0 indicates no flags.
    
    One could argue that "ice_reset_vf(vf, 0)" is no more readable than
    "ice_reset_vf(vf, false)".. However, this type of flags interface is
    somewhat common and using 0 to mean "no flags" makes sense in this
    context. We could bother to add a define for "ICE_VF_RESET_PLAIN" or
    something similar, but this can be confusing since its not an actual bit
    flag.
    
    This paves the way to add another flag to the function in a following
    change.
    Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
    Tested-by: default avatarKonrad Jankowski <konrad0.jankowski@intel.com>
    Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
    7eb517e4
ice_vf_lib.h 8.23 KB