• Milian Wolff's avatar
    perf script: Flush output stream after events in verbose mode · 7ee40678
    Milian Wolff authored
    When the perf script output is written to a terminal stream, the normal
    output of `perf script` would get buffered, but its debug output would
    be written directly. This made it quite hard to figure out where a given
    debug output is coming from.
    
    We can improve on this by flushing the output buffer after processing an
    event. To see the value, compare the following output for a `perf script
    -v` run:
    
    Before this patch:
    ```
    unwind: reg 16, val 7faf7dfdc000
    unwind: reg 7, val 7ffc80811e30
    unwind: find_proc_info dso /usr/lib/ld-2.28.so
    unwind: reg 6, val 0
    unwind: _start:ip = 0x7faf7dfdc000 (0x2000)
    unwind: reg 16, val 7faf7dfdc000
    unwind: reg 7, val 7ffc80811e30
    unwind: find_proc_info dso /usr/lib/ld-2.28.so
    unwind: reg 6, val 0
    unwind: _start:ip = 0x7faf7dfdc000 (0x2000)
    unwind: reg 16, val 7faf7dfdc000
    unwind: reg 7, val 7ffc80811e30
    unwind: find_proc_info dso /usr/lib/ld-2.28.so
    unwind: reg 6, val 0
    unwind: _start:ip = 0x7faf7dfdc000 (0x2000)
    unwind: reg 16, val 7faf7dfdc000
    unwind: reg 7, val 7ffc80811e30
    ... lots and lots of verbose debug output
    cpp-inlining 24617 90229.122036534:          1 cycles:uppp:
                7faf7dfdc000 _start+0x0 (/usr/lib/ld-2.28.so)
    
    cpp-inlining 24617 90229.122043974:          1 cycles:uppp:
                7faf7dfdc000 _start+0x0 (/usr/lib/ld-2.28.so)
    ...
    ```
    
    After this patch:
    ```
    ...
    unwind: reg 16, val 7faf7dfdc000
    unwind: reg 7, val 7ffc80811e30
    unwind: find_proc_info dso /usr/lib/ld-2.28.so
    unwind: reg 6, val 0
    unwind: _start:ip = 0x7faf7dfdc000 (0x2000)
    cpp-inlining 24617 90229.122036534:          1 cycles:uppp:
                7faf7dfdc000 _start+0x0 (/usr/lib/ld-2.28.so)
    
    unwind: reg 16, val 7faf7dfdc000
    unwind: reg 7, val 7ffc80811e30
    unwind: find_proc_info dso /usr/lib/ld-2.28.so
    unwind: reg 6, val 0
    unwind: _start:ip = 0x7faf7dfdc000 (0x2000)
    cpp-inlining 24617 90229.122043974:          1 cycles:uppp:
                7faf7dfdc000 _start+0x0 (/usr/lib/ld-2.28.so)
    ...
    ```
    
    This new output format makes it much easier to use perf script output
    for debugging purposes, e.g. to investigate broken dwarf unwinding.
    Signed-off-by: default avatarMilian Wolff <milian.wolff@kdab.com>
    Acked-by: default avatarJiri Olsa <jolsa@kernel.org>
    Link: http://lkml.kernel.org/r/20181021191424.16183-2-milian.wolff@kdab.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    7ee40678
builtin-script.c 92.2 KB