• Shida Zhang's avatar
    ext4: fix rec_len verify error · 7fda67e8
    Shida Zhang authored
    With the configuration PAGE_SIZE 64k and filesystem blocksize 64k,
    a problem occurred when more than 13 million files were directly created
    under a directory:
    
    EXT4-fs error (device xx): ext4_dx_csum_set:492: inode #xxxx: comm xxxxx: dir seems corrupt?  Run e2fsck -D.
    EXT4-fs error (device xx): ext4_dx_csum_verify:463: inode #xxxx: comm xxxxx: dir seems corrupt?  Run e2fsck -D.
    EXT4-fs error (device xx): dx_probe:856: inode #xxxx: block 8188: comm xxxxx: Directory index failed checksum
    
    When enough files are created, the fake_dirent->reclen will be 0xffff.
    it doesn't equal to the blocksize 65536, i.e. 0x10000.
    
    But it is not the same condition when blocksize equals to 4k.
    when enough files are created, the fake_dirent->reclen will be 0x1000.
    it equals to the blocksize 4k, i.e. 0x1000.
    
    The problem seems to be related to the limitation of the 16-bit field
    when the blocksize is set to 64k.
    To address this, helpers like ext4_rec_len_{from,to}_disk has already
    been introduced to complete the conversion between the encoded and the
    plain form of rec_len.
    
    So fix this one by using the helper, and all the other in this file too.
    
    Cc: stable@kernel.org
    Fixes: dbe89444 ("ext4: Calculate and verify checksums for htree nodes")
    Suggested-by: default avatarAndreas Dilger <adilger@dilger.ca>
    Suggested-by: default avatarDarrick J. Wong <djwong@kernel.org>
    Signed-off-by: default avatarShida Zhang <zhangshida@kylinos.cn>
    Reviewed-by: default avatarAndreas Dilger <adilger@dilger.ca>
    Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
    Link: https://lore.kernel.org/r/20230803060938.1929759-1-zhangshida@kylinos.cnSigned-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
    7fda67e8
namei.c 111 KB