• Johan Hovold's avatar
    USB: sierra: fix urb and memory leak in resume error path · 7fdd26a0
    Johan Hovold authored
    Neither the transfer buffer or the urb itself were released in the
    resume error path for delayed writes. Also on errors, the remainder of
    the queue was not even processed, which leads to further urb and buffer
    leaks.
    
    The same error path also failed to balance the outstanding-urb counter,
    something which results in degraded throughput or completely blocked
    writes.
    
    Fix this by releasing urb and buffer and balancing counters on errors,
    and by always processing the whole queue even when submission of one urb
    fails.
    
    Fixes: e6929a90 ("USB: support for autosuspend in sierra while
    online")
    
    Cc: <stable@vger.kernel.org>	# v2.6.32
    Signed-off-by: default avatarJohan Hovold <jhovold@gmail.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    7fdd26a0
sierra.c 29.3 KB