• Matthew Auld's avatar
    drm/i915: enable PS64 support for DG2 · 8133a6da
    Matthew Auld authored
    It turns out that on production DG2/ATS HW we should have support for
    PS64. This feature allows to provide a 64K TLB hint at the PTE level,
    which is a lot more flexible than the current method of enabling 64K GTT
    pages for the entire page-table, since that leads to all kinds of
    annoying restrictions, as documented in:
    
    commit caa574ff
    Author: Matthew Auld <matthew.auld@intel.com>
    Date:   Sat Feb 19 00:17:49 2022 +0530
    
        drm/i915/uapi: document behaviour for DG2 64K support
    
        On discrete platforms like DG2, we need to support a minimum page size
        of 64K when dealing with device local-memory. This is quite tricky for
        various reasons, so try to document the new implicit uapi for this.
    
    With PS64, we can now drop the 2M GTT alignment restriction, and instead
    only require 64K or larger when dealing with lmem. We still use the
    compact-pt layout when possible, but only when we are certain that this
    doesn't interfere with userspace.
    
    Note that this is a change in uAPI behaviour, but hopefully shouldn't be
    a concern (IGT is at least able to autodetect the alignment), since we
    are only making the GTT alignment constraint less restrictive.
    
    Based on a patch from CQ Tang.
    
    v2: update the comment wrt scratch page
    v3: (Nirmoy)
     - Fix the selftest to actually use the random size, plus some comment
       improvements, also drop the rem stuff.
    Reported-by: default avatarMichal Mrozek <michal.mrozek@intel.com>
    Signed-off-by: default avatarMatthew Auld <matthew.auld@intel.com>
    Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
    Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
    Cc: Stuart Summers <stuart.summers@intel.com>
    Cc: Jordan Justen <jordan.l.justen@intel.com>
    Cc: Yang A Shi <yang.a.shi@intel.com>
    Cc: Nirmoy Das <nirmoy.das@intel.com>
    Cc: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
    Reviewed-by: default avatarNirmoy Das <nirmoy.das@intel.com>
    Acked-by: default avatarMichal Mrozek <michal.mrozek@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20221004114915.221708-1-matthew.auld@intel.com
    8133a6da
i915_vma.c 54.7 KB