• Uwe Kleine-König's avatar
    ACPI: APEI: GHES: Convert to platform remove callback returning void · f2f212f3
    Uwe Kleine-König authored
    The .remove() callback for a platform driver returns an int which makes
    many driver authors wrongly assume it's possible to do error handling by
    returning an error code. However the value returned is ignored (apart
    from emitting a warning) and this typically results in resource leaks.
    
    To improve here there is a quest to make the remove callback return
    void. In the first step of this quest all drivers are converted to
    .remove_new(), which already returns void. Eventually after all drivers
    are converted, .remove_new() will be renamed to .remove().
    
    Instead of returning an error code, emit a better error message than the
    core. Apart from the improved error message this patch has no effects
    for the driver.
    Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
    f2f212f3
ghes.c 42.3 KB