• Julia Lawall's avatar
    [SCSI] pm8001: introduce missing kfree · 823d219f
    Julia Lawall authored
    Error handling code following a kmalloc should free the allocated data.
    
    The semantic match that finds the problem is as follows:
    (http://www.emn.fr/x-info/coccinelle/)
    
    // <smpl>
    @r exists@
    local idexpression x;
    expression E;
    identifier f,f1;
    position p1,p2;
    @@
    
    x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
    <... when != x
         when != if (...) { <+...x...+> }
         when != (x) == NULL
         when != (x) != NULL
         when != (x) == 0
         when != (x) != 0
    (
    x->f1 = E
    |
     (x->f1 == NULL || ...)
    |
     f(...,x->f1,...)
    )
    ...>
    (
     return <+...x...+>;
    |
     return@p2 ...;
    )
    
    @script:python@
    p1 << r.p1;
    p2 << r.p2;
    @@
    
    print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
    // </smpl>
    Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
    Acked-by: default avatarjack wang <jack_wang@usish.com>
    Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
    823d219f
pm8001_hwi.c 144 KB