• Imre Deak's avatar
    drm/i915/icl: Add TypeC ports only if VBT is present · 828ccb31
    Imre Deak authored
    We can't safely probe Type C ports, whether they are a legacy or a
    USB/Thunderbolt DP Alternate Type C port. This would require performing
    the TypeC connect sequence - as described by the specification - but
    that may have unwanted side-effects. These side-effects include at least
    - without completeness - timeouts during AUX power well enabling and
    subsequent PLL enabling errors.
    
    To safely identify these ports we really need VBT, which has the proper
    flag for this (ddi_vbt_port_info::supports_typec_usb, supports_tbt).
    Based on the above disable Type C ports if we can't load VBT for some
    reason.
    
    v2:
    - Notice that we disable TypeC ports completely and simplify accordingly
      (Jose).
    - Add code comment explaining why we disabled the ports. (Jani)
    
    Cc: Jani Nikula <jani.nikula@intel.com>
    Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
    Cc: Jose Roberto de Souza <jose.souza@intel.com>
    Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
    Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
    Signed-off-by: default avatarImre Deak <imre.deak@intel.com>
    Reviewed-by: default avatarJosé Roberto de Souza <jose.souza@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20190128114242.28666-1-imre.deak@intel.com
    828ccb31
intel_bios.c 60.6 KB