• Marc Zyngier's avatar
    KVM: arm64: Get rid of host SVE tracking/saving · 8383741a
    Marc Zyngier authored
    The SVE host tracking in KVM is pretty involved. It relies on a
    set of flags tracking the ownership of the SVE register, as well
    as that of the EL0 access.
    
    It is also pretty scary: __hyp_sve_save_host() computes
    a thread_struct pointer and obtains a sve_state which gets directly
    accessed without further ado, even on nVHE. How can this even work?
    
    The answer to that is that it doesn't, and that this is mostly dead
    code. Closer examination shows that on executing a syscall, userspace
    loses its SVE state entirely. This is part of the ABI. Another
    thing to notice is that although the kernel provides helpers such as
    kernel_neon_begin()/end(), they only deal with the FP/NEON state,
    and not SVE.
    
    Given that you can only execute a guest as the result of a syscall,
    and that the kernel cannot use SVE by itself, it becomes pretty
    obvious that there is never any host SVE state to save, and that
    this code is only there to increase confusion.
    
    Get rid of the TIF_SVE tracking and host save infrastructure altogether.
    Reviewed-by: default avatarMark Brown <broonie@kernel.org>
    Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
    8383741a
kvm_host.h 24.8 KB