• Michael Brunner's avatar
    mfd: kempld-core: Don't replace resources provided by ACPI · 87bfb48f
    Michael Brunner authored
    The current implementation to retrieve ACPI resources is faulty
    and may cause issues that even can lead to non-booting systems.
    
    When adding data from an ACPI device, the resources are already
    assigned to the platform device. Therefore there is no need to
    retrieve the resource list from ACPI and manually assign it to
    the platform device. Also there shouldn't be any BIOS in the wild
    anymore, that does not have resources added to the KEMPLD ACPI
    data.
    
    In particular this fixes an issue where the retrieval of the
    resource list using /proc/ioports is disturbed and does not list
    the assigned resource for the kempld device or even no resources
    at all.
    On some distributions this also leads to problems during system
    initialization (e.g. with udev) and causes the system to not
    boot at all.
    
    I have reproduced the issue with the following kernel versions:
        5.10.209
        5.15.148
        6.1.25
        6.6.17
        6.7.5
        6.8-rc5
    
    The patch applies to all of those versions and seems to resolve
    the issue.
    Signed-off-by: default avatarMichael Brunner <michael.brunner@kontron.com>
    Link: https://lore.kernel.org/r/af8756be81c9062f9543d2e5d9373cf5e7877b1e.camel@kontron.comSigned-off-by: default avatarLee Jones <lee@kernel.org>
    87bfb48f
kempld-core.c 25.1 KB