• Namhyung Kim's avatar
    perf test: Fix cpu and thread map leaks in perf_time_to_tsc test · 846580c2
    Namhyung Kim authored
    It should release the maps at the end.
    
      $ perf test -v 71
      71: Convert perf time to TSC                   :
      --- start ---
      test child forked, pid 178744
      mmap size 528384B
      1st event perf time 59207256505278 tsc 13187166645142
      rdtsc          time 59207256542151 tsc 13187166723020
      2nd event perf time 59207256543749 tsc 13187166726393
    
      =================================================================
      ==178744==ERROR: LeakSanitizer: detected memory leaks
    
      Direct leak of 40 byte(s) in 1 object(s) allocated from:
        #0 0x7faf601f9e8f in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
        #1 0x55b620cfc00a in cpu_map__trim_new /home/namhyung/project/linux/tools/lib/perf/cpumap.c:79
        #2 0x55b620cfca2f in perf_cpu_map__read /home/namhyung/project/linux/tools/lib/perf/cpumap.c:149
        #3 0x55b620cfd1ef in cpu_map__read_all_cpu_map /home/namhyung/project/linux/tools/lib/perf/cpumap.c:166
        #4 0x55b620cfd1ef in perf_cpu_map__new /home/namhyung/project/linux/tools/lib/perf/cpumap.c:181
        #5 0x55b6209ef1b2 in test__perf_time_to_tsc tests/perf-time-to-tsc.c:73
        #6 0x55b6209828fb in run_test tests/builtin-test.c:428
        #7 0x55b6209828fb in test_and_print tests/builtin-test.c:458
        #8 0x55b620984a53 in __cmd_test tests/builtin-test.c:679
        #9 0x55b620984a53 in cmd_test tests/builtin-test.c:825
        #10 0x55b6209f0cd4 in run_builtin /home/namhyung/project/linux/tools/perf/perf.c:313
        #11 0x55b62087aa88 in handle_internal_command /home/namhyung/project/linux/tools/perf/perf.c:365
        #12 0x55b62087aa88 in run_argv /home/namhyung/project/linux/tools/perf/perf.c:409
        #13 0x55b62087aa88 in main /home/namhyung/project/linux/tools/perf/perf.c:539
        #14 0x7faf5fd2fd09 in __libc_start_main ../csu/libc-start.c:308
    
      SUMMARY: AddressSanitizer: 72 byte(s) leaked in 2 allocation(s).
      test child finished with 1
      ---- end ----
      Convert perf time to TSC: FAILED!
    Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
    Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Ian Rogers <irogers@google.com>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Leo Yan <leo.yan@linaro.org>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Link: https://lore.kernel.org/r/20210301140409.184570-12-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    846580c2
perf-time-to-tsc.c 4.4 KB