• Kees Cook's avatar
    alpha: Silence -Warray-bounds warnings · 545c2722
    Kees Cook authored
    GCC 11 (incorrectly[1]) assumes that literal values cast to (void *)
    should be treated like a NULL pointer with an offset, and raises
    diagnostics when doing bounds checking:
    
    In function '__memset',
        inlined from '__bad_pagetable' at arch/alpha/mm/init.c:79:2:
    ./arch/alpha/include/asm/string.h:37:32: error: '__builtin_memset' offset [0, 8191] is out of the bounds [0, 0] [-Werror=array-bounds]
       37 |                         return __builtin_memset(s, c, n);
          |                                ^~~~~~~~~~~~~~~~~~~~~~~~~
    In function '__memset',
        inlined from '__bad_page' at arch/alpha/mm/init.c:86:2:
    ./arch/alpha/include/asm/string.h:37:32: error: '__builtin_memset' offset [0, 8191] is out of the bounds [0, 0] [-Werror=array-bounds]
       37 |                         return __builtin_memset(s, c, n);
          |                                ^~~~~~~~~~~~~~~~~~~~~~~~~
    In function '__memset',
        inlined from 'paging_init' at arch/alpha/mm/init.c:256:2:
    ./arch/alpha/include/asm/string.h:37:32: error: '__builtin_memset' offset [0, 8191] is out of the bounds [0, 0] [-Werror=array-bounds]
       37 |                         return __builtin_memset(s, c, n);
    
    This has been solved in other places[2] already by using the recently
    added absolute_pointer() macro. Do the same here.
    
    [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99578
    [2] https://lore.kernel.org/all/20210912160149.2227137-1-linux@roeck-us.net/
    
    Cc: Richard Henderson <rth@twiddle.net>
    Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
    Cc: Matt Turner <mattst88@gmail.com>
    Cc: Guenter Roeck <linux@roeck-us.net>
    Cc: linux-alpha@vger.kernel.org
    Reviewed-and-tested-by: default avatarGuenter Roeck <linux@roeck-us.net>
    Signed-off-by: default avatarKees Cook <keescook@chromium.org>
    545c2722
init.c 7.46 KB