• Paul Burton's avatar
    MIPS: Setup boot_command_line before plat_mem_setup · 8ce355cf
    Paul Burton authored
    Platforms using DT will typically call __dt_setup_arch from
    plat_mem_setup. This in turn calls early_init_dt_scan. When
    CONFIG_CMDLINE is set, this leads to its value being copied into
    boot_command_line by early_init_dt_scan_chosen. If this happens before
    the code setting up boot_command_line in arch_mem_init runs, that code
    will go on to append CONFIG_CMDLINE (via builtin_cmdline) to
    boot_command_line again, duplicating it. For some command line
    parameters (eg. earlycon) this can be a problem. Set up
    boot_command_line before early_init_dt_scan_chosen gets called such that
    it will not write CONFIG_CMDLINE in this scenario & the arguments aren't
    duplicated.
    Signed-off-by: default avatarPaul Burton <paul.burton@mips.com>
    Acked-by: default avatarMathieu Malaterre <malat@debian.org>
    Cc: Ralf Baechle <ralf@linux-mips.org>
    Cc: Maarten ter Huurne <maarten@treewalker.org>
    Cc: linux-mips@linux-mips.org
    Patchwork: https://patchwork.linux-mips.org/patch/18483/Signed-off-by: default avatarJames Hogan <jhogan@kernel.org>
    8ce355cf
setup.c 25.3 KB