• Ido Schimmel's avatar
    net/sched: act_gact: Add extack messages for offload failure · 69642c2a
    Ido Schimmel authored
    For better error reporting to user space, add extack messages when gact
    action offload fails.
    
    Example:
    
     # echo 1 > /sys/kernel/tracing/events/netlink/netlink_extack/enable
    
     # tc filter add dev dummy0 ingress pref 1 proto all matchall skip_sw action continue
     Error: cls_matchall: Failed to setup flow action.
     We have an error talking to the kernel
    
     # cat /sys/kernel/tracing/trace_pipe
           tc-181     [002] b..1.   105.493450: netlink_extack: msg=act_gact: Offload of "continue" action is not supported
           tc-181     [002] .....   105.493466: netlink_extack: msg=cls_matchall: Failed to setup flow action
    
     # tc filter add dev dummy0 ingress pref 1 proto all matchall skip_sw action reclassify
     Error: cls_matchall: Failed to setup flow action.
     We have an error talking to the kernel
    
     # cat /sys/kernel/tracing/trace_pipe
           tc-183     [002] b..1.   124.126477: netlink_extack: msg=act_gact: Offload of "reclassify" action is not supported
           tc-183     [002] .....   124.126489: netlink_extack: msg=cls_matchall: Failed to setup flow action
    
     # tc filter add dev dummy0 ingress pref 1 proto all matchall skip_sw action pipe action drop
     Error: cls_matchall: Failed to setup flow action.
     We have an error talking to the kernel
    
     # cat /sys/kernel/tracing/trace_pipe
           tc-185     [002] b..1.   137.097791: netlink_extack: msg=act_gact: Offload of "pipe" action is not supported
           tc-185     [002] .....   137.097804: netlink_extack: msg=cls_matchall: Failed to setup flow action
    Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
    Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    69642c2a
act_gact.c 8.99 KB