• Chen Zhongjin's avatar
    perf trace: Fix show_arg_names not working for tp arg names · 888964a0
    Chen Zhongjin authored
    trace__fprintf_tp_fields() will always print arg names because when
    implemented it is forced to print arg_names with:
    
      (1 || trace->show_arg_names)
    
    So the printing looks like:
    
    > cat ~/.perfconfig
        [trace]
            show_arg_names = no
    
    > perf trace -e syscalls:*mmap sleep 1
        0.000 sleep/1119 syscalls:sys_enter_mmap(NULL, 8192, READ|WRITE, PRIVATE|ANONYMOUS)
        0.179 sleep/1119 syscalls:sys_exit_mmap(__syscall_nr: 9, ret: 140535426170880)
        ...
    
    Although the comment said that perhaps we need a show_tp_arg_names.
    
    I don't think it's necessary to control them separately because it's not
    so clean that part of the log shows arg names but other not.
    
    Also when we are tracing functions it's rare to especially distinguish
    syscalls and tp trace.
    
    Only use one option to control arg names printing is more resonable and
    simple. So remove the force condition and commit.
    
    After fix:
    
    > perf trace -e syscalls:*mmap sleep 1
        0.000 sleep/1121 syscalls:sys_enter_mmap(NULL, 8192, READ|WRITE, PRIVATE|ANONYMOUS)
        0.163 sleep/1121 syscalls:sys_exit_mmap(9, 140454467661824)
        ...
    
    Fixes: f11b2803 ("perf trace: Allow choosing how to augment the tracepoint arguments")
    Signed-off-by: default avatarChen Zhongjin <chenzhongjin@huawei.com>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Florian Fischer <florian.fischer@muhq.space>
    Cc: Ian Rogers <irogers@google.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: John Garry <john.garry@huawei.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: http://lore.kernel.org/lkml/20220926031440.28275-2-chenzhongjin@huawei.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    888964a0
builtin-trace.c 148 KB