• Athira Rajeev's avatar
    perf test bpf: Skip test if clang is not present · 8994e97b
    Athira Rajeev authored
    Perf BPF filter test fails in environment where "clang" is not
    installed.
    
    Test failure logs:
    
    <<>>
     42: BPF filter                    :
     42.1: Basic BPF filtering         : Skip
     42.2: BPF pinning                 : FAILED!
     42.3: BPF prologue generation     : FAILED!
    <<>>
    
    Enabling verbose option provided debug logs which says clang/llvm needs
    to be installed. Snippet of verbose logs:
    
    <<>>
     42.2: BPF pinning                  :
     --- start ---
    test child forked, pid 61423
    ERROR:	unable to find clang.
    Hint:	Try to install latest clang/llvm to support BPF.
            Check your $PATH
    
    <<logs_here>>
    
    Failed to compile test case: 'Basic BPF llvm compile'
    Unable to get BPF object, fix kbuild first
    test child finished with -1
     ---- end ----
    BPF filter subtest 2: FAILED!
    <<>>
    
    Here subtests, "BPF pinning" and "BPF prologue generation" failed and
    logs shows clang/llvm is needed. After installing clang, testcase
    passes.
    
    Reason on why subtest failure happens though logs has proper debug
    information:
    
    Main function __test__bpf calls test_llvm__fetch_bpf_obj by
    passing 4th argument as true ( 4th arguments maps to parameter
    "force" in test_llvm__fetch_bpf_obj ). But this will cause
    test_llvm__fetch_bpf_obj to skip the check for clang/llvm.
    
    Snippet of code part which checks for clang based on
    parameter "force" in test_llvm__fetch_bpf_obj:
    
    <<>>
    if (!force && (!llvm_param.user_set_param &&
    <<>>
    
    Since force is set to "false", test won't get skipped and fails to
    compile test case. The BPF code compilation needs clang, So pass the
    fourth argument as "false" and also skip the test if reason for return
    is "TEST_SKIP"
    
    After the patch:
    
    <<>>
     42: BPF filter                    :
     42.1: Basic BPF filtering         : Skip
     42.2: BPF pinning                 : Skip
     42.3: BPF prologue generation     : Skip
    <<>>
    
    Fixes: ba1fae43 ("perf test: Add 'perf test BPF'")
    Reviewed-by: default avatarKajol Jain <kjain@linux.ibm.com>
    Signed-off-by: default avatarAthira Jajeev <atrajeev@linux.vnet.ibm.com>
    Acked-by: default avatarIan Rogers <irogers@google.com>
    Cc: Disha Goel <disgoel@linux.vnet.ibm.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: linuxppc-dev@lists.ozlabs.org
    Cc: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
    Cc: Michael Ellerman <mpe@ellerman.id.au>
    Cc: Nageswara R Sastry <rnsastry@linux.ibm.com>
    Cc: Wang Nan <wangnan0@huawei.com>
    Link: https://lore.kernel.org/r/20220511115438.84032-1-atrajeev@linux.vnet.ibm.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    8994e97b
bpf.c 8.83 KB