• Chao Yu's avatar
    f2fs: fix to avoid data corruption by forbidding SSR overwrite · 899fee36
    Chao Yu authored
    There is one case can cause data corruption.
    
    - write 4k to fileA
    - fsync fileA, 4k data is writebacked to lbaA
    - write 4k to fileA
    - kworker flushs 4k to lbaB; dnode contain lbaB didn't be persisted yet
    - write 4k to fileB
    - kworker flush 4k to lbaA due to SSR
    - SPOR -> dnode with lbaA will be recovered, however lbaA contains fileB's
    data
    
    One solution is tracking all fsynced file's block history, and disallow
    SSR overwrite on newly invalidated block on that file.
    
    However, during recovery, no matter the dnode is flushed or fsynced, all
    previous dnodes until last fsynced one in node chain can be recovered,
    that means we need to record all block change in flushed dnode, which
    will cause heavy cost, so let's just use simple fix by forbidding SSR
    overwrite directly.
    
    Fixes: 5b6c6be2 ("f2fs: use SSR for warm node as well")
    Signed-off-by: default avatarChao Yu <yuchao0@huawei.com>
    Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
    899fee36
segment.c 116 KB