• Baoquan He's avatar
    mips, kexec: fix the incorrect ifdeffery and dependency of CONFIG_KEXEC · 8cd2accb
    Baoquan He authored
    The select of KEXEC for CRASH_DUMP in kernel/Kconfig.kexec will be
    dropped, then compiling errors will be triggered if below config items are
    set:
    
    ===
    CONFIG_CRASH_CORE=y
    CONFIG_KEXEC_CORE=y
    CONFIG_CRASH_DUMP=y
    ===
    
    --------------------------------------------------------------------
    mipsel-linux-ld: kernel/kexec_core.o: in function `kimage_free':
    kernel/kexec_core.c:(.text+0x2200): undefined reference to `machine_kexec_cleanup'
    mipsel-linux-ld: kernel/kexec_core.o: in function `__crash_kexec':
    kernel/kexec_core.c:(.text+0x2480): undefined reference to `machine_crash_shutdown'
    mipsel-linux-ld: kernel/kexec_core.c:(.text+0x2488): undefined reference to `machine_kexec'
    mipsel-linux-ld: kernel/kexec_core.o: in function `kernel_kexec':
    kernel/kexec_core.c:(.text+0x29b8): undefined reference to `machine_shutdown'
    mipsel-linux-ld: kernel/kexec_core.c:(.text+0x29c0): undefined reference to `machine_kexec'
    --------------------------------------------------------------------
    
    Here, change the dependency of building kexec_core related object files,
    and the ifdeffery in mips from CONFIG_KEXEC to CONFIG_KEXEC_CORE.
    
    Link: https://lkml.kernel.org/r/20231208073036.7884-4-bhe@redhat.comSigned-off-by: default avatarBaoquan He <bhe@redhat.com>
    Reported-by: default avatarkernel test robot <lkp@intel.com>
    Closes: https://lore.kernel.org/oe-kbuild-all/202311302042.sn8cDPIX-lkp@intel.com/
    Cc: Eric DeVolder <eric_devolder@yahoo.com>
    Cc: Ignat Korchagin <ignat@cloudflare.com>
    Cc: Stephen Rothwell <sfr@canb.auug.org.au>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    8cd2accb
smp.c 12.4 KB