• Frederic Weisbecker's avatar
    sched/cputime: Spare a seqcount lock/unlock cycle on context switch · 8d495477
    Frederic Weisbecker authored
    On context switch we are locking the vtime seqcount of the scheduling-out
    task twice:
    
     * On vtime_task_switch_common(), when we flush the pending vtime through
       vtime_account_system()
    
     * On arch_vtime_task_switch() to reset the vtime state.
    
    This is pointless as these actions can be performed without the need
    to unlock/lock in the middle. The reason these steps are separated is to
    consolidate a very small amount of common code between
    CONFIG_VIRT_CPU_ACCOUNTING_GEN and CONFIG_VIRT_CPU_ACCOUNTING_NATIVE.
    
    Performance in this fast path is definitely a priority over artificial
    code factorization so split the task switch code between GEN and
    NATIVE and mutualize the parts than can run under a single seqcount
    locked block.
    
    As a side effect, vtime_account_idle() becomes included in the seqcount
    protection. This happens to be a welcome preparation in order to
    properly support kcpustat under vtime in the future and fetch
    CPUTIME_IDLE without race.
    Signed-off-by: default avatarFrederic Weisbecker <frederic@kernel.org>
    Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Rik van Riel <riel@redhat.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Wanpeng Li <wanpengli@tencent.com>
    Cc: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
    Link: https://lkml.kernel.org/r/20191003161745.28464-3-frederic@kernel.orgSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    8d495477
cputime.c 22.5 KB