• Paulo Zanoni's avatar
    drm/i915: check the power well when redisabling VGA · 8dc8a27c
    Paulo Zanoni authored
    If the power well is disabled VGA is guaranteed to be disabled.
    
    This fixes unclaimed register messages that happen on suspend/resume.
    
    v2: Check the actual hw power well state instead of our own tracking
    to make sure VGA is _really_ off (in case the BIOS/KVMr has just its
    own request bit set). Requested by Ville.
    
    Note: Ville suggested whether it wouldn't be better to just enable the
    power well over a slightly longer time in our resume code, since we
    already do that. I tend to agree, but there's also the modeset force
    code in the lid notifier which _also_ eventually calls redisable_vga.
    We shouldn't ever need this on somewhat modern hw (everything with
    opregion essentially) but the code to bail out isn't there. Hence
    stick with this simple approach here for now.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67517Signed-off-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
    [danvet: Summarize the discussion around the resume sequence and lid
    notifier a bit.]
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    8dc8a27c
intel_display.c 286 KB