• Amir Goldstein's avatar
    fuse: fix illegal access to inode with reused nodeid · 15db1683
    Amir Goldstein authored
    Server responds to LOOKUP and other ops (READDIRPLUS/CREATE/MKNOD/...)
    with ourarg containing nodeid and generation.
    
    If a fuse inode is found in inode cache with the same nodeid but different
    generation, the existing fuse inode should be unhashed and marked "bad" and
    a new inode with the new generation should be hashed instead.
    
    This can happen, for example, with passhrough fuse filesystem that returns
    the real filesystem ino/generation on lookup and where real inode numbers
    can get recycled due to real files being unlinked not via the fuse
    passthrough filesystem.
    
    With current code, this situation will not be detected and an old fuse
    dentry that used to point to an older generation real inode, can be used to
    access a completely new inode, which should be accessed only via the new
    dentry.
    
    Note that because the FORGET message carries the nodeid w/o generation, the
    server should wait to get FORGET counts for the nlookup counts of the old
    and reused inodes combined, before it can free the resources associated to
    that nodeid.
    Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
    Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
    15db1683
readdir.c 13.7 KB