• Namhyung Kim's avatar
    perf annotate: Update DSO binary type when trying build-id · 8f3ec810
    Namhyung Kim authored
    dso__disassemble_filename() tries to get the filename for objdump (or
    capstone) using build-id.  But I found sometimes it didn't disassemble
    some functions.
    
    It turned out that those functions belong to a DSO which has no binary
    type set.  It seems it sets the binary type for some special files only
    - like kernel (kallsyms or kcore) or BPF images.  And there's a logic to
    skip dso with DSO_BINARY_TYPE__NOT_FOUND.
    
    As it's checked the build-id cache link, it should set the binary type
    as DSO_BINARY_TYPE__BUILD_ID_CACHE.
    
    Fixes: 873a8373 ("perf annotate: Skip DSOs not found")
    Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Ian Rogers <irogers@google.com>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Kan Liang <kan.liang@linux.intel.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: https://lore.kernel.org/r/20240425005157.1104789-2-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    8f3ec810
disasm.c 43.6 KB