• Frank Li's avatar
    arm64: dts: imx8-ss-dma: fix pwm lpcg indices · 9055d87b
    Frank Li authored
    adma_pwm_lpcg: clock-controller@5a590000 {
    	...							 col1 col2
    	clocks = <&clk IMX_SC_R_LCD_0_PWM_0 IMX_SC_PM_CLK_PER>,// 0   0
    		 <&dma_ipg_clk>;                               // 1   4
    	clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_4>;
            ...
    };
    
    Col1: index, which existing dts try to get.
    Col2: actual index in lpcg driver.
    
    adma_pwm: pwm@5a190000 {
    	...
    	clocks = <&adma_pwm_lpcg 1>, <&adma_pwm_lpcg 0>;
    				 ^^		     ^^
    Should be
    	clocks = <&adma_pwm_lpcg IMX_LPCG_CLK_4>,
    		 <&adma_pwm_lpcg IMX_LPCG_CLK_0>;
    };
    
    Arg0 will be divided by 4 in lcpg driver, so pwm will get IMX_SC_PM_CLK_PER
    by <&adma_pwm_lpcg 1>, <&adma_pwm_lpcg 0>. Although function can work, code
    logic is wrong. Fix it by use correct indices.
    
    Cc: stable@vger.kernel.org
    Fixes: f1d6a6b9 ("arm64: dts: imx8qxp: add adma_pwm in adma")
    Signed-off-by: default avatarFrank Li <Frank.Li@nxp.com>
    Signed-off-by: default avatarShawn Guo <shawnguo@kernel.org>
    9055d87b
imx8-ss-dma.dtsi 16.6 KB