• NeilBrown's avatar
    rhashtable: add lockdep tracking to bucket bit-spin-locks. · 149212f0
    NeilBrown authored
    Native bit_spin_locks are not tracked by lockdep.
    
    The bit_spin_locks used for rhashtable buckets are local
    to the rhashtable implementation, so there is little opportunity
    for the sort of misuse that lockdep might detect.
    However locks are held while a hash function or compare
    function is called, and if one of these took a lock,
    a misbehaviour is possible.
    
    As it is quite easy to add lockdep support this unlikely
    possibility seems to be enough justification.
    
    So create a lockdep class for bucket bit_spin_lock and attach
    through a lockdep_map in each bucket_table.
    
    Without the 'nested' annotation in rhashtable_rehash_one(), lockdep
    correctly reports a possible problem as this lock is taken
    while another bucket lock (in another table) is held.  This
    confirms that the added support works.
    With the correct nested annotation in place, lockdep reports
    no problems.
    Signed-off-by: default avatarNeilBrown <neilb@suse.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    149212f0
rhashtable.c 29.6 KB