• Tatsunosuke Tobita's avatar
    HID: wacom: generic: Avoid reporting a serial of '0' to userspace · ab41a31d
    Tatsunosuke Tobita authored
    The xf86-input-wacom driver does not treat '0' as a valid serial
    number and will drop any input report which contains an
    MSC_SERIAL = 0 event. The kernel driver already takes care to
    avoid sending any MSC_SERIAL event if the value of serial[0] == 0
    (which is the case for devices that don't actually report a
    serial number), but this is not quite sufficient.
    Only the lower 32 bits of the serial get reported to userspace,
    so if this portion of the serial is zero then there can still
    be problems.
    
    This commit allows the driver to report either the lower 32 bits
    if they are non-zero or the upper 32 bits otherwise.
    Signed-off-by: default avatarJason Gerecke <jason.gerecke@wacom.com>
    Signed-off-by: default avatarTatsunosuke Tobita <tatsunosuke.tobita@wacom.com>
    Fixes: f85c9dc6 ("HID: wacom: generic: Support tool ID and additional tool types")
    CC: stable@vger.kernel.org # v4.10
    Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
    ab41a31d
wacom_wac.c 158 KB