• Masahiro Yamada's avatar
    kbuild: rename cmd_$@ to savedcmd_$@ in *.cmd files · 92215e7a
    Masahiro Yamada authored
    The cmd-check macro compares $(cmd_$@) and $(cmd_$1), but a pitfall is
    that you cannot use cmd_<target> as the variable name for the command.
    
    For example, the following code will not work in the top Makefile
    or ./Kbuild.
    
        quiet_cmd_foo = GEN     $@
              cmd_foo = touch $@
    
        targets += foo
        foo: FORCE
                $(call if_changed,foo)
    
    In this case, both $@ and $1 are expanded to 'foo', so $(cmd_check)
    is always empty.
    
    We do not need to use the same prefix for cmd_$@ and cmd_$1.
    Rename the former to savedcmd_$@.
    Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
    Reviewed-by: default avatarNicolas Schier <nicolas@fjasle.eu>
    92215e7a
Kbuild.include 9.74 KB