• Ville Syrjälä's avatar
    drm/i915: Make .get_dplls() return int · 9274229a
    Ville Syrjälä authored
    Get rid of the confusing back and forth between bools and ints
    in the .get_dplls() stuff. Just make everything return an int.
    
    Initial conversion done with cocci, with some manual fixups on top:
    @find@
    identifier func !~ "get_hw_state|_is_|needed";
    typedef bool;
    parameter list[N] P;
    @@
    - bool
    + int
     func(P)
    {
    <...
    (
    - return true;
    + return 0;
    |
    - return false;
    + return -EINVAL;
    )
    ...>
    }
    
    @@
    identifier find.func;
    expression list[find.N] E;
    expression X;
    @@
    - if (!func(E))
    + ret = func(E);
    + if (ret)
      {
      ...
    - return X;
    + return ret;
      }
    
    @@
    identifier find.func;
    expression X;
    expression list[find.N] E;
    @@
    - if (!func(E))
    + ret = func(E);
    + if (ret)
    - return X;
    + return ret;
    
    @@
    identifier find.func;
    expression list[find.N] E;
    expression O, X;
    typedef bool;
    bool B;
    @@
    - B = func(E);
    - if (O && !B)
    + if (O) {
    + ret = func(E);
    + if (ret)
    - return X;
    + return ret;
    + }
    
    @@
    identifier find.func;
    expression list[find.N] E;
    expression O, X;
    @@
    - if (O && !func(E))
    + if (O) {
    + ret = func(E);
    + if (ret)
    - return X;
    + return ret;
    + }
    
    @@
    identifier find.func;
    expression list[find.N] E;
    expression X;
    typedef bool;
    bool B;
    @@
    - B = func(E);
    - if (!B)
    + ret = func(E);
    + if (ret)
      {
      ...
    - return X;
    + return ret;
      }
    Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20220325123205.22140-2-ville.syrjala@linux.intel.comReviewed-by: default avatarJani Nikula <jani.nikula@intel.com>
    9274229a
intel_dpll_mgr.h 9.14 KB