• Paolo Bonzini's avatar
    KVM: nSVM: clarify recalc_intercepts() wrt CR8 · 74905e3d
    Paolo Bonzini authored
    The mysterious comment "We only want the cr8 intercept bits of L1"
    dates back to basically the introduction of nested SVM, back when
    the handling of "less typical" hypervisors was very haphazard.
    With the development of kvm-unit-tests for interrupt handling,
    the same code grew another vmcb_clr_intercept for the interrupt
    window (VINTR) vmexit, this time with a comment that is at least
    decent.
    
    It turns out however that the same comment applies to the CR8 write
    intercept, which is also a "recheck if an interrupt should be
    injected" intercept.  The CR8 read intercept instead has not
    been used by KVM for 14 years (commit 649d6864, "KVM: SVM:
    sync TPR value to V_TPR field in the VMCB"), so do not bother
    clearing it and let one comment describe both CR8 write and VINTR
    handling.
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    74905e3d
nested.c 49 KB