• Bob Copeland's avatar
    mwifiex: fix error handling in mwifiex_create_custom_regdomain · 92ca4f92
    Bob Copeland authored
    smatch reports:
    
    sta_cmdresp.c:1053 mwifiex_create_custom_regdomain() warn: possible memory leak of 'regd'
    
    Indeed, mwifiex_create_custom_regdomain() returns NULL in the
    case that channel is missing in the TLV without freeing regd.
    
    Moreover, some other error paths in this function return ERR_PTR
    values which are assigned without checking to the regd field in
    the mwifiex_adapter struct.  The latter is only null-checked where
    used.
    
    Fix by freeing regd in the error path, and only update
    priv->adapter->regd if the returned pointer is valid.
    
    Cc: Amitkumar Karwar <akarwar@marvell.com>
    Cc: Nishant Sarmukadam <nishants@marvell.com>
    Signed-off-by: default avatarBob Copeland <me@bobcopeland.com>
    Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
    92ca4f92
sta_cmdresp.c 39.9 KB