• Dan Carpenter's avatar
    crypto: marvell/octeontx - Fix a potential NULL dereference · 1f5b07f5
    Dan Carpenter authored
    Smatch reports that:
    
        drivers/crypto/marvell/octeontx/otx_cptvf_algs.c:132 otx_cpt_aead_callback()
        warn: variable dereferenced before check 'cpt_info' (see line 121)
    
    This function is called from process_pending_queue() as:
    
    drivers/crypto/marvell/octeontx/otx_cptvf_reqmgr.c
       599                  /*
       600                   * Call callback after current pending entry has been
       601                   * processed, we don't do it if the callback pointer is
       602                   * invalid.
       603                   */
       604                  if (callback)
       605                          callback(res_code, areq, cpt_info);
    
    It does appear to me that "cpt_info" can be NULL so this could lead to
    a NULL dereference.
    
    Fixes: 10b4f094 ("crypto: marvell - add the Virtual Function driver for CPT")
    Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    1f5b07f5
otx_cptvf_algs.c 44.5 KB